Clean up of monarch_rdma/extension #528
Closed
+40
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78276671 |
allenwang28
force-pushed
the
export-D78276671
branch
from
d89b480 to
652fc75
Compare
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Jul 15, 2025
Summary: Follow up to D76937776 - Reverts some objects back to `pub(super)`, exposing the relevant needed APIs - Cleanups of monarch_rdma/extension/lib.rs Reviewed By: colin2328, vidhyav Differential Revision: D78276671
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Jul 15, 2025
Summary: Follow up to D76937776 - Reverts some objects back to `pub(super)`, exposing the relevant needed APIs - Cleanups of monarch_rdma/extension/lib.rs Reviewed By: colin2328, vidhyav Differential Revision: D78276671
allenwang28
force-pushed
the
export-D78276671
branch
from
652fc75 to
91063e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78276671 |
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Jul 15, 2025
Summary: Pull Request resolved: pytorch-labs#528 Follow up to D76937776 - Reverts some objects back to `pub(super)`, exposing the relevant needed APIs - Cleanups of monarch_rdma/extension/lib.rs Reviewed By: colin2328, vidhyav Differential Revision: D78276671
|
This pull request was exported from Phabricator. Differential Revision: D78276671 |
allenwang28
force-pushed
the
export-D78276671
branch
from
91063e0 to
2415be8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78276671 |
Summary: Pull Request resolved: pytorch-labs#528 Follow up to D76937776 - Reverts some objects back to `pub(super)`, exposing the relevant needed APIs - Cleanups of monarch_rdma/extension/lib.rs Reviewed By: colin2328, vidhyav Differential Revision: D78276671
allenwang28
force-pushed
the
export-D78276671
branch
from
2415be8 to
c4fb77b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78276671 |
|
This pull request has been merged in dd496a4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up to D76937776
pub(super), exposing the relevant needed APIsDifferential Revision: D78276671